fix(studio,producer): post-merge regressions — fixes #1636, #1637, #1644#1643
Merged
Conversation
c411fc5 to
a393011
Compare
a393011 to
14ce288
Compare
d873697 to
6e0f4ad
Compare
- fix gsapDragCommit.test.ts import for commitGsapPositionFromDrag - add generateId() helper with insecure-context fallback (fixes #1637) - enable STUDIO_KEYFRAMES_ENABLED by default - prevent clock duration from shrinking during playback (fixes #1636) - add maxRetries to rmSync cleanup calls to handle ENOTEMPTY race (fixes #1644)
6e0f4ad to
b5034b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes CI failures and open issues after the keyframe editing stack merge (#1605).
CI fix
gsapDragCommit.test.tsimportedcommitGsapPositionFromDragfromgsapDragCommitbut it was extracted togsapDragPositionCommitFixes #1637 —
crypto.randomUUID is not a functionon plain HTTPgenerateId()helper with insecure-context fallback (Date.now()-Math.random()) for all 6 call sites across 5 filesFixes #1636 — Live preview freezes after ~10s, playhead jumps to end
clock.setDuration()was called every tick with a DOM-derived duration. A transient shorter read (fromsanitizeCompositionDurationAttributesstripping sub-comp attrs mid-tick) would shrink the duration →reachedEnd()fires → playhead jumps to endFixes #1644 — ENOTEMPTY race on worker directory cleanup
rmSync({recursive: true})walks the tree, removes files, thenrmdir— but Chrome writes a new file between the walk and the rmdirmaxRetries: 3, retryDelay: 100tormSyncin the three cleanup paths (orchestrator, distributed chunk, shared cleanup helper)Enable keyframes
STUDIO_KEYFRAMES_ENABLEDdefault fromfalsetotrueTest plan
bun test packages/studio/src/hooks/gsapDragCommit.test.ts— 12/12 pass